-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instances to Cli and enable remote vs local run configurations #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt versions for each run config
steezeburger
requested changes
Apr 2, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a few extra comments for some cleanup, but I am going to go ahead and approve because it looks good!
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
reviewed
Apr 3, 2024
steezeburger
added a commit
that referenced
this pull request
Apr 5, 2024
* main: Add instances to Cli and enable remote vs local run configurations (#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
init
,run
, andclean
commands now have an--instance
flag to create multiple configurations with the cli to enable configuring and running several instances of the Astria stack at the same time.Currently, detailed configuration of each instance is manual once the directory has been initialized.
The
init
command now also creates both local and remote, config and binary folders for running a sequencer locally or using a remote sequencer.The
run
command now has an--local
and a--remote
flag to chose if you are running a local sequencer or using a remote one.